Log viewer background colors should be full height
Summary
Background color support was recently introduced: #474840 (closed)
However, the background color doesn't fully extend to the line-height, which makes our log viewer have a noticeable difference to terminal emulators.
Steps to reproduce
Execute the following job for a ANSI color code Pokemon:
pikachu:
script:
- curl pkmn.li/25/
Relevant logs and/or screenshots
HTML viewer | JS Job viewer | Terminal |
---|---|---|
Possible fixes
For JS viewer:
-
span
should usedisplay: inline-block
, which ensures thatbackground-color
is full height.
For HTML viewer:
-
span
should usedisplay: inline-block
, which ensures thatbackground-color
is full height. -
.job-log-line
should removemin-height
and remove top and bottom padding. This changes very little to the line heights (so readability is essentially unaffected), but fixes this problem.