Refactor package details installation tabs
What does this MR do?
Currently, on the package details page there are some installation instructions displayed on the right hand side. There are dedicated components for each of these per package type (e.g. conan_installation.vue
, maven_installation.vue
, etc). Previously, each of these components contained their own GlTabs
and each one implemented event tracking on tab change, which needed to be tested.
This MR contains a refactoring to create a new shared component called InstallationTabs
. This wraps GlTabs
and encapsulates all the tracking logic applied on tab change, etc. The result is that we can drop testing of tab change tracking on individual components and reduce a lot of repetitiveness.
Screenshots
No visual changes.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines - [-] Style guides
- [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team