Move populate_scheduling_type logic
What does this MR do?
Related to #217458 (closed)
As we've discussed, we need to move
populate_scheduling_type!
logic fromCi::ProcessPipelineService
toCi::RetryPipelineService
andexecute
method ofCi::RetryBuildService
in order to reduce the number of calls to Redis.
Just in case, we added FF ci_ensure_scheduling_type
to rollback this change easily. Created a follow-up issue for this.
- It is unlikely that there is a bug here, but we want to add a feature flag to ensure that new pipelines can be processed correctly and retried correctly if something goes wrong
- Only legacy pipelines that are a couple of months old would be affected by toggling the feature flag
- Simplifying the pipeline processing and removing Redis from this equation seems to be more important than unlikely possibility of breaking retries of very old pipelines (creating a new pipeline in these project will still work).
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Grzegorz Bizon