Support setting environment values for registry
Summary
Some parts of Gitlab support setting arbitrary environment values (which we can find using /opt/gitlab/etc/<>/env
)
However, registry
is an example of one part that does not support env values.
Proposal
Add a new variable in gitlab.rb to support environment values for registry
(such as setting a http proxy).
It would look like registry['env'] = {"http_proxy" => "http://proxy"}
.
New changes:
- add
default['registry']['env'] = nil
anddefault['registry']['env_dir'] = "/opt/gitlab/etc/registry"
. - Use code similar to the gitaly part for the recipe. https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/files/gitlab-cookbooks/gitaly/recipes/enable.rb
- Use the env in the runsv script (here https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/files/gitlab-cookbooks/registry/templates/default/sv-registry-run.erb) like https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/files/gitlab-cookbooks/gitlab/templates/default/sv-sidekiq-run.erb#L8
References
Similar issues: