Reconfigure is not creating all 90-omnibus-gitlab-* files in /opt/gitlab/embedded/etc

Summary

Running reconfigure will not always create the files in /opt/gitlab/embedded/etc/ and ensure the symbolic links between /etc/sysctl.d and /opt/gitlab/embedded/etc

Discovered during customer tickets when the action is to uninstall/install GitLab to provide a clean install of /opt/gitlab.

Of the four links - /opt/gitlab/embedded/etc/90-omnibus-gitlab-kernel.shmmax.conf is recreated as part of reconfigure.

Can these files in /opt/gitlab/embedded/etc be moved to

• /var/opt/gitlab/etc which currently doesn't exist or
• /etc/gitlab ?

Steps to reproduce

1. Remove directory rm -rf /opt/gitlab/embedded/etc/
2. Run reconfigure sudo gitlab-ctl reconfigure

What is the current bug behavior?

Output from gitlab-ctl reconfigure

STDERR: 
sysctl: cannot open "/etc/sysctl.d/90-omnibus-gitlab-kernel.sem.conf": No such file or directory
sysctl: cannot open "/etc/sysctl.d/90-omnibus-gitlab-kernel.shmall.conf": No such file or directory      
sysctl: cannot open "/etc/sysctl.d/90-omnibus-gitlab-net.core.somaxconn.conf": No such file or directory
---- End output of sysctl -e --system ----                                                               
Ran sysctl -e --system returned 255

It does create /opt/gitlab/embedded/etc/90-omnibus-gitlab-kernel.shmmax.conf

# ls -l /opt/gitlab/embedded/etc
total 8
-rw-r--r--. 1 root root  28 Feb  5 14:59 90-omnibus-gitlab-kernel.shmmax.conf
-rwxr-xr-x. 1 root root 261 Feb  5 14:58 gitconfig

What is the expected correct behavior?

All files in /opt/gitlab/embedded/etc/ to be recreated.

Details of package version

Provide the package version installation details

Confirmed reproducible on 12.7.5.

Environment details

• Operating System: Ubunt1804/Centos7 (only tested these)
• Installation Target, remove incorrect values:
  • Bare Metal Machine
  • VM: Digital Ocean, AWS, GCP, Azure, Other

Links

ZD: https://gitlab.zendesk.com/agent/tickets/144365 (internal use only)