Support units other than milliseconds for the pg-upgrade timeout option
Summary
The current timeout option for pg-upgrade is in milliseconds. We should support other, more human friendly units as well.
Proposal
We should preserve the current default behavior, but I think we should support single letter suffixes to specify the unit. i.e. -T 12s
.
We probably only need to support seconds, minutes, hours, and possibly days.
References
Availability and Testing
What risks does this change pose to our availability?
None, just a timeout option during upgrade
How might it affect the quality of the product?
No impact
What additional test coverage or changes to tests will be needed?
Additional unit testing required.
- Ensure time with no unit is treated as ms
- Ensure each new time unit is correctly tracked
- Check for bad unit characters
Will it require cross-browser testing?
Not tested at the browser level
Edited by Hossein Pursultani