Sidekiq will now fail to configure if sidekiq_cluster config is used
Our automated Nightly Omnibus test environments started failing today on the standalone Sidekiq nodes will the following error during reconfigure:
There was an error running gitlab-ctl reconfigure:
resource templatesymlink[Create a database.yml and create a symlink to Rails root] is configured to notify resource runit_service[sidekiq] with action restart, but runit_service[sidekiq] cannot be found in the resource collection. templatesymlink[Create a database.yml and create a symlink to Rails root] is defined in /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/gitlab-rails.rb:175:in `from_file'
The issue appears to be related to using the deprecated sidekiq_cluster
config parameters as switching to the new config sorted the issue. Of note when debugging this I noticed there was both a sidekiq
service and a sidekiq_cluster
service reported by gitlab-ctl status
.
While sidekiq_cluster
config is deprecated it should still be working up until it's removal in 14.0 so at this time this is an issue.
Edited by Grant Young