Make the `apply_source_link` parameter of the `Reaction#add_comment` mandatory
The following discussion from !1500 (merged) should be addressed:
-
@leetickett started a discussion: (+3 comments) Hey @rymai thank you for volunteering
You and I worked together on the initial implementation. Ash then helped get the previous MR over the line applying it to half of the processors, and now @ali_o_kan has kindly raised this MR to apply to the remaining processors.
I did just have an after thought (sorry). Perhaps to make it more obvious that we have deliberately chosen not to
apply_source_link
to the remaining "comments" (because they are quick action only), should we setapply_source_link: false
instead of allowing it to simply assume the default value? And perhaps we make it a required parameter rather than optional? Of course we would probably do this in a follow up.Thanks!
Implementation Guide
We'd need to modify the methods' signatures at https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/2c9ccd563189db4cba14d034c37eaa8c970ef668/triage/triage/reaction.rb#L9, https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/2c9ccd563189db4cba14d034c37eaa8c970ef668/triage/triage/reaction.rb#L15, and https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/2c9ccd563189db4cba14d034c37eaa8c970ef668/triage/triage/reaction.rb#L21.