Allow title to use placeholders and Ruby expression, too
In gitlab-org/quality/triage-ops!83 (diffs, comment 132699198) we're sharing the title for both issues rule and merge requests rule, and if we can't use placeholders or Ruby expression then they'll be using the same title.
We should also allow title to use placeholders and Ruby expression. I expect something like this will do the trick:
diff --git a/lib/gitlab/triage/entity_builders/issue_builder.rb b/lib/gitlab/triage/entity_builders/issue_builder.rb
index bb1b5ca..ec487ec 100644
--- a/lib/gitlab/triage/entity_builders/issue_builder.rb
+++ b/lib/gitlab/triage/entity_builders/issue_builder.rb
@@ -6,12 +6,11 @@ module Gitlab
module Triage
module EntityBuilders
class IssueBuilder
- attr_reader :title
attr_writer :description, :items
def initialize(action, resources, network)
- @title = action[:title]
@item_template = action[:item]
+ @title_template = action[:title]
@summary_template = action[:summary]
@redact_confidentials =
action[:redact_confidential_resources] != false
@@ -19,6 +18,17 @@ module Gitlab
@network = network
end
+ def title
+ return '' unless @title_template
+
+ @title ||= CommandBuilders::TextContentBuilder.new(
+ @title_template,
+ resource: {},
+ network: @network,
+ redact_confidentials: @redact_confidentials)
+ .build_command
+ end
+
def description
return '' unless @summary_template
Edited by Lin Jen-Shin