Skip to content

Avoid join->send race condition by joining long before the message send (sync join events)

Eric Eastwood requested to merge 2770-sync-joins-to-matrix into develop

Avoid join->send race condition by joining long before the message send

Fix #2770 (closed)

If we join on Matrix when the user joins the room on Gitter, there will be a significant gap of time to allow the join event to federate before the user sends a message.

The underlying Synapse race condition could still be triggered if the user was fast enough to join and send a message right away (plus the variable amount of lag between each piece in the chain).

Testing strategy

  1. Leave and join a room on Gitter
  2. Notice the leave and join events on Matrix

Edited by Eric Eastwood

Merge request reports