pslaughter
Hi!
My schedule has changed!
For the foreseeable future, this is my schedule:
I spend the work week with 80% focus time and 20% flex time.
-
Focus time is where I am free from distractions and can easily take meetings, solve hard problems, and get in The-Groove
™️ . - Flex time is where I will be sporadically online for short periods. During this time I can contirbute to discussions asynchronously, take care of small code reviews, and make small contributions.
This is distributed across the week as:
- 90+% of the week's focus time is on Tuesday, Thursday, Friday and Saturday. I'm available for most of the day these days.
- Monday and Wednesday I am mostly unavailable. I might have some Flex time on these days depending on what's going on.
On Code Review
Here's my favorite way to efficiently review MR’s
Shifting to review mode
- Close all tabs. Close editors. Close distractions.
- Open my list of MR’s to review. Open a clean terminal with the gdk running on the latest
gitlab
master branch. Open my editor.
For each review
-
Start a timer (personally, I shoot for either 15m or 10m). The whole review might take longer. This just helps keep track of how much time has passed. Anticipate how many "time blocks" it should take to finish the review, and try to wrap things up during the last block.
-
Read context
-
Review code locally. Instead of changing branches, I like to apply the MR diff and stage changes to do this.
curl URL_TO_MR.diff | git apply && git add –-all
-
High level read-through. Code smells or maintainability issues? Duplicate code? Low cohesion? Modules or functions getting too big? Is the code fragile? Potential user-facing issues?
-
Review test coverage. Are there blocks of untested code (mutation testing FTW!)? Do we need to test at additional levels?
-
Line-for-line read-through. Undesirable low-level patterns? Polishing opportunities? Is the code fragile? Potential user-facing issues?
-
Manual exploratory testing. Were there any potential user-facing issues I can confirm based on the previous read-throughs?
-
If necessary, convert notes to actionable comments.
-
Finish!
Personal projects
View allAbout
Staff Fullstack Engineer, Group::Remote Development at GitLab