Skip to content

Limit the number of simultaneously open not actively used content files (#6756)

elsid requested to merge elsid/openmw:esm_readers_cache into master

Use LRU cache for ESMReaders. When cache capacity is reached close least recently used ESMReader. Remember the file name if a reader was open. Once the reader requested again open the file if there is stored name for it. Put released ESMReader to the back of the free items list. Close ESMReader's from the front of the free items list.

Cached item can be used only by one client at the same time. If the same item is requested twice exception is thrown. This should never happen in practice. If this happens need to fix the client logic.

It's allowed to go over the capacity limit when requesting different readers. Ideally this should never happen but there will be system error anyway signalizing about too many open files. Need to fix client logic in this case.

Default cache capacity is 100 items. Need additional testing to determine the optimal value.

All places that were using a vector of ESMReaders now using the cache. Cache is local for each use case and there is no need for a thread safety.

Fixes #6756 (closed).

Edited by elsid

Merge request reports

Loading