Skip to content

eyeo/auxiliary/issue#123 - Update Filter Lists Between App Updates

Dean Murphy requested to merge issue/123-add-filter-list-updateing into develop

Changes

  • Set filterlists to copy from main bundle to shared container in following instances:
    • App is first run (existing behaviour)
    • App Version Number changes between launches (new behaviour)
      • If there are items in whitelist, whitelist will be applied to new filter list.
  • Added short delay (2 seconds) to the reloadContentBlocker() function call when app launches.
    • Just a precautionary measure to allow slower machines to complete file updates
    • Will add a more elegant solution in future refactoring

Testing Notes

  • Remove previous builds
  • Delete Folder: ~/Library/Group Containers/GRYYZR985A.org.adblockplus.adblockplussafarimac
  • Run Terminal Command: killall -u $USER cfprefsd
  • Install 2.0.1 from App Store and launch/enable
  • Whitelist a domain (not youtube)
  • Visit youtube.com and experience ads (pre-roll and banner overlay on video)
  • Visit whitelisted domain and experience ads
  • Install 2.0.2 and launch
    • Content blocker should update filter lists in folder: ~/Library/Group Containers/GRYYZR985A.org.adblockplus.adblockplussafarimac
    • Content Blocker should apply whitelist
    • Content blocker should reload itself automagically
  • Visit youtube.com and pre-roll/banner overlay ads should be removed
  • Visit whitelisted domain and experience ads
Edited by Dean Murphy

Merge request reports