Skip to content

Forbid percentage of time feature flags in chatops

Omar Qunsul requested to merge 425428-disallowing-time-percentage-feature-flags into master

Addressing: gitlab-org/gitlab#425428 (closed)

Changelog: other

Context

We are deprecating time percentage feature flags in favor of context/actor feature flags. That's because time percentage FF (random) that are not tied to any context can cause major outages. This was the recent S1 incident. With this MR we are deprecating them in preparation to convert all the current time percentage FFs to roll them out to 100% or enable them on actors only

Validation of this MR locally

  1. Checkout this branch 425428-disallowing-time-percentage-feature-flags
  2. Run this command in terminal env SLACK_TOKEN='SLACK_XXX' GITLAB_TOKEN='GITLAB_XXX' CHAT_INPUT='set test_feature 0.5 --random' CHAT_CHANNEL='SLACK_CHANNEL_ID' bundle exec ./bin/chatops feature. You should get a deprecation error.
  3. Adding --ignore-deprecation-check will work, but it will output another unrelated error because we are not fully testing chatops integrated with Slack env SLACK_TOKEN='SLACK_XXX' GITLAB_TOKEN='GITLAB_XXX' CHAT_INPUT='set test_feature 0.5 --random --ignore-random-deprecation-check' CHAT_CHANNEL='SLACK_CHANNEL_ID' bundle exec ./bin/chatops feature
Edited by Omar Qunsul

Merge request reports