Skip to content

Mention potential issue creation for JiHu impacted breakage

Peter Leitzen requested to merge splattael-main-patch-efc8 into main

Why is this change being made?

In the handbook it’s unclear whether to create an issue or not.

It only reads

drop a reference in the issue or merge request, and move on

It's not clear where to drop a reference if no related items (issues, MRs) can be found.

Tracking progress in an issue as opposed to an MR (which might unrelated, or already merged) might be a tad more work but we could:

  • Contact Martin Tan (JiHu) by assigning it to them
  • Reduce the noise on unrelated or closed MRs/issues
  • Make this issue as a single source of truth for potential follow-ups/corrective actions
  • Measure the amount of created issues with “JiHu Broken Pipeline” label applied, if needed

This was discussed in Quality: Engineering Productivity Weekly.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Peter Leitzen

Merge request reports