Skip to content

Fix broken Manage team tables

Martin Wortschack requested to merge mw-fix-manage-team-table into master

Why is this change being made?

We recently converted Manage EMs to Fullstack EMs in gitlab-org/manage/general-discussion#17454. This change also led to a change of reporting relationships and caused the Manage team tables in the handbook to not render correctly.

This MR fixes the broken Manage team table on https://about.gitlab.com/handbook/engineering/development/dev.

It also formats team member role links to be consistent with the rest of the page, i.e., the link only contains the role and not the team.

Before

manage_team_table_before

After

Team
Auth manage_auth_after
Compliance manage_compliance_after
Import manage_import_after
Optimize manage_optimize_after
Workspace manage_workspace_after

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this change to the correct DRI(s)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR.
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Dennis Tang

Merge request reports

Loading