Add Steve Abrams as backend maintainer
Trainee maintainer issue: #13277 (closed)
🗺 Overview
I've worked at GitLab as a backend engineer in ~"group::package" since May 2019.
- 811 MRs reviewed since starting
- Over 237 MRs reviewed as ~backend reviewer (It is difficult to filter MRs that had Database reviews to see which ones I was backend reviewer for rather than Database reviewer).
- 390 MRs authored and merged
- Database maintainer of
gitlab-org/gitlab
since December 2020 - Database maintainer of
gitlab-org/container-registry
formally since April 2022 - MR coach - 136 community MRs reviewed
📰 Examples of reviews
- Harbor repositorie/artifacts/tags APIs (gitlab-org/gitlab!82777 - merged)
- Delete container repository worker: add registr... (gitlab-org/gitlab!88997 - merged)
- Accept user param for the member activate service (gitlab-org/gitlab!86340 - merged)
- Remove the pipelines field from the package ver... (gitlab-org/gitlab!86773 - merged)
- Allow anonymous access to public Conan packages (gitlab-org/gitlab!54047 - merged)
- Add support for the Container Registry new tags... (gitlab-org/gitlab!94065 - merged)
- Draft: Return ActionRecord::Collection from exe... (gitlab-org/gitlab!53763 - closed)
📈 Things to improve
I have been feeling more and more confident with my reviews and in unfamiliar areas of code. I believe taking on the responsibility of maintainership will help me continue to expand my expertise and further push myself to trust my judgement and grow my confidence.
Self-assessed areas to improve
- Manage my time better in reviews by asking questions when I'm uncertain about what something I don't understand is doing rather than spending a long time working it out myself. In other words, make my reviews more collaborative.
- Continue to learn about more domains in the app that I have not had as much exposure to.
- Secure code guidelines. I feel confident in my general awareness of security, but there are so many little things in this topic, there is always more to learn and look out for.
Self-assessed strengths
- Awareness of when I'm unsure about something and need to ask for help.
- Positive and engaging reviews.
- Domain expertise in all package stage features and also all areas of authentication (API Guard, controllers,
Gitlab::Auth
for Git and JWT related features) and authorization (declarative policy framework). - Focus on development and performance guidelines as well as educating everyone involved.
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist :check
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days (this will be true on 2022-08-12) -
If we have 10 or fewer backend maintainers, more than half of the existing maintainers approve the MR, otherwise if we have 11 or more maintainers, 5 existing maintainers approve the MR (see the maintainer list) -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Steve Abrams