Add Manoj as backend maintainer
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. -
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
@manojmj has been a Senior Backend Engineer at GitLab now for 3.5 years and in that time:
- He has authored 271 merge requests, many of which have been quite complex such as disabling Ultimate features for public projects with no activity or involving numerous specialties
- He has reviewed/approved 314 merge requests, with nearly half of these being groups outside of any devopsmanage groups
- He has a great understanding of the GitLab codebase and in particular quality and scalability due to the pressure of the groups he's been in (Auth and Workspace)
- He has a history of identifying problems/gaps during code review [1, 2, 3, 4]
- He has received very positive feedback from existing maintainers already
Before Merging(Manager Tasks)
-
Mention the maintainers from the given specialty and ask them to provide feedback directly on this merge request. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org/<project>
. -
Join the backend-maintainers
slack group -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to @gitlab-org/maintainers/rails-backend
-
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Edited by Michelle Gill