Make bwill a backend maintainer
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. -
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
Some recent examples of MRs authored by @bwill:
- Maintainer experience improvement: Add script for reviewing project template changes (gitlab-org/gitlab!106726 - merged)
- Developer experience improvement: Skip running lefthook on master (gitlab-org/gitlab!105221 - merged)
- Feature: Add verified badge for SSH signed commits (gitlab-org/gitlab!97248 - merged)
- Feature enhancement: Add `purl_type` to sbom_components (gitlab-org/gitlab!100759 - merged)
And recent examples of MRs reviewed by @bwill:
- Community contribution: Cleans up `ssh commit signatures` ~"feature flag" (gitlab-org/gitlab!106176 - merged)
- Suggestion to make code more legible: gitlab-org/gitlab!106995 (comment 1210915284)
- Suggestions to improve specs: gitlab-org/gitlab!100510 (comment 1130427649)
- Frontend / Backend integration stability: gitlab-org/gitlab!106723 (comment 1207766193)
Before Merging (Manager Tasks)
-
Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org/<project>
. -
Join the #backend_maintainers
Slack channel -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to @gitlab-org/maintainers/rails-backend
-
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
Edited by Brian Williams