Skip to content

Product designer MR review guidelines update

Gina Doyle requested to merge master-patch-e9d6 into master

Why is this change being made?

Now that some groups do not have product design DRIs, there are times when MRs may propose features that need some extra design capacity during the MR review to ensure features are following Pajamas and general UX guidance. I don't think these review guidelines should differ much from what's already documented, but I did try adding some extra tips for these scenarios, and an example.

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Gina Doyle

Merge request reports

Loading