Skip to content

Removing optional flag for Tech Stack and CODEOWNERS files within CODEOWNERS

Kyle Smith requested to merge ks-tech-stack-codeowners-update into master

Why is this change being made?

Tech Stack CODEOWNER Update

Original idea started here. Tech Stack updates have downstream operational impacts including:

  1. Ability to contact DRIs of system and ensuring access (de-)provisioning capabilities are in place
  2. Scoping consideration for regulatory or compliance programs
  3. Okta integration opportunities

We have defined templates for adding, updating, and removing systems. These templates provide guidance that changes should not be made without review of the Business Technology team who verifies that specific actions have been taken prior to merge. While these templates are in place, there is no technical enforcement of this requirement that prevents updates to the Tech Stack file without ensuring the appropriate steps are taken.

Updating the CODEOWNERS file to include a required section for the Tech Stack file and enabling Code owner approval on https://gitlab.com/gitlab-com/www-gitlab-com would require a review by Business Technology that would validate whether the appropriate steps have been taken prior to merging.

CODEOWNER Section Update

In order to reduce the risk that someone will circumvent required code owner approvals, we need to remove optional flag (^) from the CODEOWNER section within CODEOWNERS which would require an approval from the code owner for the CODEOWNERS file to approve prior to merge (related convo). We should identify more people or a group to identify as code owners from the CODEOWNERS file as it's currently set to @sytses @timzallmann.

Updated the codeowners to remove @sytses and add @gitlab-com/ceo-chief-of-staff-team based on feedback given here.

Communication of change

If this change is made including enabling the Code Owner Approval feature for the master branch in the www-gitlab-com repository, we will communicate it out to whats-happening-at-gitlab

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Kyle Smith

Merge request reports

Loading