Adjust guidelines for trainee maintainers
Based on that discussion: https://gitlab.slack.com/archives/C0AR2KW4B/p1682324194863219
On our handbook page regarding how to become a maintainer https://about.gitlab.com/handbook/engineering/workflow/code-review/#learning-to-be-a-maintainer, there is a suggestion to either add oneself as a reviewer
or trainee_maintainer
.
Create a merge request and indicate your role as a project-name: reviewer or project-name: trainee_maintainer
This OR
is confusing since our reviewing guidelines mention that:
Trainee maintainers with
🔵 :large_blue_circle:
are three times as likely to be picked as other reviewers.
Given that: we should update the docs, since being a reviewer
and trainee_maintainer
same time is confusing readers and the roulette.
Author Checklist
-
Provided a concise title for this Merge Request (MR) -
Added a description to this MR explaining the reasons for the proposed change, per say why, not just what - Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
-
Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI) - If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
Maintained by
section on the page being edited - If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
- The when to get approval handbook section explains the workflow in more detail
- If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
-
If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR - If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.
Edited by Chase Southard