Skip to content

Add newline pipeline failure note and fix bullet formatting

Daniel Murphy requested to merge daniel-murphy-newline-pipeline-2023-05-09 into master

Why is this change being made?

The instructions on the Edit this website locally handbook page fail to warn team members about the newline requirement to avoid the pipeline linter failure. See this example: !124275 (comment 1383485296)

Additionally there were some formatting errors in the bullet list that prevented most of the bullets and made it very difficult to read.

This MR changes the .erb partial that is used to populate the Edit this website locally page.

Screenshots

Before

Screenshot_2023-05-09_at_9.53.11_AM

After

Screenshot_2023-05-09_at_10.02.45_AM

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Daniel Murphy

Merge request reports

Loading