Skip to content

Add maddievn as backend maintainer

John Mason requested to merge jm-add-maddievn-as-backend-maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

Maddie has been at GitLab since September, 2022, and at the time of this writing has reviewed approximately 153 MRs. She cares about providing reviews in a timely manner and to consider the impact of a change and if any follow ups or next steps are needed.

She is most experienced in reviewing search-related code, low-level application changes and middleware, authentication/authorization, AI and CI pipelines to highlight some areas. She would like to upskill towards becoming good at reviewing database changes in particular.

Some notable MRs that were reviewed by Maddie include:

title url
GitHub import: status of import for each relation-type tab (Raised security/compliance risk regarding access_tokens) gitlab-org/gitlab!113778 (comment 1305074012)
Indexing for newly created GroupWiki gitlab-org/gitlab!120171 (merged)
Run Up/Down migrations for database migration tests on both databases gitlab-org/gitlab!118234 (merged)
Adds new services to handle MlModel packages gitlab-org/gitlab!121247 (merged)
Enable anti-spam for notes gitlab-org/gitlab!122257 (merged)
Support to log user git push activity again gitlab-org/gitlab!112527 (merged)

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action 
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement please approve or give a 👍 on the MR

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  3. Let a maintainer add you to @gitlab-org/maintainers/rails-backend
  4. Announce it everywhere
  5. Keep reviewing, start merging 🤘 😎 🤘
Edited by Changzheng Liu

Merge request reports