Skip to content

Remove the need for a worker per-MR

Gonzalo Servat requested to merge use-kv-for-review-reduce-workers into master

Why is this change being made?

With the worker-per-MR approach, we may potentially have too many workers if enough open MRs land and we really don't need a worker per MR. If there are no code changes, then we should be using the one worker (called about-gitlab-com-review).

The approach in this MR simplifies the set-up and uses a single worker for all review apps UNLESS the MR contains changes to the worker code, in which case it does get its own worker (so you can test the changes there).

The other change is that for review apps, we check if there is a key in KV for the MR. If there is, that means there are changes to the redirects.yml in the MR, so we use those redirects for that site.

Best of both worlds - massively reduce the number of workers but still have the flexibility to test worker code changes + redirects per MR!

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.
Edited by Gonzalo Servat

Merge request reports