Skip to content

Add Dylan, John Mason, Rutger as reviewers for the gitlab-chart

Dylan Griffith requested to merge add-dylan-john-rutger-as-reviewers-for-gitlab-chart into master

Why is this change being made?

All of us have expressed an interest in becoming reviewers and gaining expertise of the GitLab chart https://gitlab.com/gitlab-org/charts/gitlab . Adding ourselves here as reviewers means we'll be able to start this process. Initially we might have to work from the Distribution dashboard queue but in the near future we may be exploring adding reviewer roulette to this project so you can get assigned MRs to review the same way we do for GitLab.

The current expectation for reviewers is:

  1. Assign yourself as the reviewer and add the label "workflow::in-review"
  2. Review in a timely manner
  3. Validate the author has followed the expectations outlined in the checklist
  4. Once you're happy then approve and pass along to a maintainer for this project. At present the only active maintainers for gitlab-chart are Jason Plum and Mitch Nielsen so please pick one of them

Also see https://about.gitlab.com/handbook/engineering/development/enablement/systems/distribution/merge_requests.html

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.
Edited by Dylan Griffith

Merge request reports