Skip to content

Return proper headers for 404s in review apps

Gonzalo Servat requested to merge return-proper-404-headers into master

Why is this change being made?

When we got a 404 from the origin in review apps, we were fetching the 404 page but returning the headers for that last request instead of the original request.

This issue only affects review apps. New production (cf.about.gitlab.com) would have been working fine as that uses c.storage.googleapis.com, which returns 404 headers and the 404 page content as the body so there is no extra request.

Reported in https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/18945#note_1450196281.

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Gonzalo Servat

Merge request reports

Loading