Add Aboobacker MK as a backend maintainer
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. -
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
Contributions and evidence of thorough reviews
Aboobacker joined last year and just completed his first year anniversary at GitLab. During this time he has made valuable contributions on multiple bug fixes (including vulnerabilities), added support for external groups within OIDC authentication flow, decoupled the OTP and WebAuthn enablement on GitLab.com and more recently converted the authorization query to a linear query. In the course of his work he approved 85 MRs and authored 52 MRs
Aboobacker:
- Encourages code comments when code is obvious gitlab-org/gitlab!104284 (comment 1175322125)
- Ensure that the backward compatibility is considered gitlab-org/gitlab!102048 (comment 1171283662), gitlab-org/gitlab!123162 (comment 1431044166)
- Ensure i18n is properly applied for error messages gitlab-org/gitlab!100229 (comment 1124619890)
- Security related feedback for related projects https://gitlab.com/gitlab-private/gl-security/engineering-and-research/automation-team/escalator/appsec-escalator/-/merge_requests/24
- Ensure error handling in API is cleaner gitlab-org/gitlab!104248 (comment 1175698029)
- Paired with the MR owner to identify the issue gitlab-org/gitlab!109486 (merged)
- Reviewed community MRs and encourage the contributor to make use of Gitlab community forks gitlab-org/gitlab!115200 (comment 1333106335)
- Encourage more readable code gitlab-org/gitlab!116152 (comment 1335299605)
- Discussed code practices in Slack when there were different perspectives existed gitlab-org/gitlab!123424 (comment 1433806934)
- Review potential security issues gitlab-org/gitlab!122636 (comment 1430390134)
- Identifies the larger issues while reviewing the code gitlab-org/gitlab!123891 (comment 1433402664)
- Ensure that Changelog will be readable gitlab-org/gitlab!126464 (comment 1478699405)
- Reduce the scope of breaking changes gitlab-org/gitlab!126721 (comment 1472896939)
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty with the template below. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Template call to action
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT.
* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement please approve or give a 👍 on the MR
After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.
Once This MR is Merged
-
Join the #backend_maintainers
Slack channel -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to @gitlab-org/maintainers/rails-backend
-
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘