Skip to content

Maintainers should be added with Owner access level

Manoj M J requested to merge mmj-maintership-owner into master

Why is this change being made?

Imagine the following scenario:

  • Clark is already a backend Maintainer
  • Rebecca is announced as a new backend Maintainer

When a new maintainer is announced, they are supposed to be added to groups of their specific expertise (like rails-backend). The checklist for Maintainers currently says:

Let a maintainer add you to `@gitlab-org/maintainers/rails-backend`

However, this does not specify the access level with which the new maintainer must be added. Also, Clark will have the ability to add Rebecca to the group only if Clark is already an OWNER in the group, as only owners have ability within a group to add new members.

So, definitely, new Maintainers should be getting Owner access levels within these groups, and this MR makes that point explicit in the checklist.

Related Slack Conversation: Internal only

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Merge request reports