Skip to content

Update FF guidance with additional examples

Adil Farrukh requested to merge adil.farrukh-master-patch-61560 into master

Why is this change being made?

As part of the incident and the following review, a slack discussion suggested revising the examples provided for feature flag use to include destructive data operations and the use of finders to be explicitly called out.

Screenshot_2023-07-16_at_9.59.59_PM

Relates to: Review and revise feature flag guidance for Man... (gitlab-org/gitlab#418564 - closed)

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Adil Farrukh

Merge request reports

Loading