Skip to content

Clarify expectations for feature flags and finders

Alex Ives requested to merge master-patch-e408 into master

Why is this change being made?

The current feature flag documentation suggests that all use of finders should be wrapped in feature flags, but since finders are tyipcally mundane and well tested, this is reworded to explicitly call out reusing complex finders in new ways. New finders are already covered by introducing complex queries.

We want to make sure we're not discouraging the use of finders since they're an important tool for isolating queries in testable units. Finders also automatically trigger database review, meaning that the queries are extensively reviewed.

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Alex Ives

Merge request reports

Loading