Skip to content

Redirect index

Gonzalo Servat requested to merge redirect-index into master

Why is this change being made?

This MR redirects /index/? to the same path minus the /index/? at the Cloudflare worker level instead of using a middleware (as proposed in gitlab-com/marketing/digital-experience/buyer-experience!2565 (closed)).

Also included a couple of small changes that will have no effect on the worker's current behavior.

❯ curl -s -o /dev/null -w "%{redirect_url}\n" https://redirect-index.about.gitlab-review.app/abc/def/index
https://redirect-index.about.gitlab-review.app/abc/def/

❯ curl -s -o /dev/null -w "%{redirect_url}\n" https://redirect-index.about.gitlab-review.app/abc/def/index/
https://redirect-index.about.gitlab-review.app/abc/def/

Related: gitlab-com/marketing/digital-experience/buyer-experience#2578 (closed)

Author Checklist

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Gonzalo Servat

Merge request reports

Loading