Make Dzmitry Meshcharakou a backend maintainer
Manager Justification
It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".
-
The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes. - Add runner tags selection for on-demand scans form (gitlab-org/gitlab!103634 - merged)
- Add package_type validation to Packages::Compos... (gitlab-org/gitlab!110777 - merged)
- Adds field public_package to package details gr... (gitlab-org/gitlab!111992 - merged)
- Add Metrics Dashboard templates viewer to FF (gitlab-org/gitlab!120289 - merged)
- https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/3241+
- ModelsController now displays Ml::Model (gitlab-org/gitlab!127011 - merged)
- List workItems at the group level MVC 1 (gitlab-org/gitlab!126089 - merged)
- Feat: implement report abuse in user profile (gitlab-org/gitlab!127326 - merged)
- Refactor Package Pipelines endpoint (gitlab-org/gitlab!127113 - merged)
- Add Groups::SshCertificate model to store group... (gitlab-org/gitlab!127856 - merged)
-
The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes. - Introduce a model for npm metadata (gitlab-org/gitlab!114312 - merged)
- Mitigate the race condition when creating a new... (gitlab-org/gitlab!114317 - merged)
- Update the lease key to contain package's version (gitlab-org/gitlab!116782 - merged)
- Implement package metadata endpoint on the grou... (gitlab-org/gitlab!119073 - merged)
- Implement npm group level endpoints: CRUD tags ... (gitlab-org/gitlab!120900 - merged)
- Use metadata cache for npm metadata endpoint at... (gitlab-org/gitlab!122686 - merged)
- Remove last_of_each_version scope and add uniqu... (gitlab-org/gitlab!123923 - merged)
- Add docker distribution manifest list v2 type t... (gitlab-org/gitlab!127545 - merged)
- Create dependency-proxy bucket when setup objec... (gitlab-org/gitlab-development-kit!3291 - merged)
- Fix error reporting when user is not authorized (gitlab-org/gitlab!129346 - merged)
@dmeshcharakou has reviewed over 123 merged MRs and authored over 84 merged MRs
Trainee Backend Maintainer issue: Trainee BE maintainer (GitLab) - Dzmitry Meshch... (#14356 - closed)
Backend Maintainer Mentor: @splattael
- Focuses on changes in MR and code quality 1, 2, 3
- Cares about performance impact 1, 2
- Encourages code readability and suggests re-use existing code when possible 1, 2, 3, 4
- Identifies and suggests adding missing tests and improves test quality 1, 2, 3, 4, 5, 6
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty with the template below. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Template call to action
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT.
* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement please approve or give a 👍 on the MR
After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.
Once This MR is Merged
-
Join the #backend_maintainers
Slack channel -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to @gitlab-org/maintainers/rails-backend
withOwner
access level. -
Announce it everywhere -
Familiarize yourself with documentation for Merging a merge request -
Keep reviewing, start merging 🤘 😎 🤘