Skip to content

Make Eugie Limpin a backend maintainer

Eugie Limpin requested to merge el-become-a-maintainer into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

Eugie has reviewed 200+ merged MRs and has authored 200+ MRs.

He strives to follow Gitlab's Code Review values when performing reviews:

  • Focuses on quality of the MR:
    • UX (1, 2, 3)
    • Reliability (1, 2)
    • Maintainability (1, 2)
    • Readability (1, 2, 3, 4, 5)
    • Testing (1, 2 3, 4 5, 6)
    • Consistency (1, 2, 3, 4, 5)
  • Prioritizes unblocking others and supports other team members during reviews (1, 2, 3)
  • Maintains honesty during reviews - asks the author and other reviewers if he doesn't understand something (1, 2, 3)

While he is ready to become a maintainer, he also recognizes improvement points he can work on as he continues to review code:

  • Become more familiar with and look out for security risks during review (1)
  • Ask for help from / collaborate with other reviewers/maintainers when in doubt or to get a sanity check

Backend trainee maintainer's mentor: Thong Kuah @tkuah

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action 
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement please approve or give a 👍 on the MR

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  3. Let a maintainer add you to @gitlab-org/maintainers/rails-backend with Owner access level.
  4. Announce it everywhere
  5. Familiarize yourself with documentation for Merging a merge request
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Eugie Limpin

Merge request reports