Skip to content

Remove private links to 1pwd vaults

Nailia Iskhakova requested to merge docs-remove-private-1pwd-links into master

Why is this change being made?

After internal discussion with Security team related to gitlab-org/quality/performance!524 (comment 1526469814), they identified that using plain text guidance for vault items is preferable over private links.

The MR removes private links to vaults and changes text to use plain text.

Worth noting that Private links in the changed examples are safe as they require authentication and access to the vault to work, but as Security team called out plain text is preferable.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Merge request reports