Skip to content

Clean up - delete partials that aren't being used or have duplicate content

Christen Dybenko requested to merge master-patch-41e5 into master

Why is this change being made?

In this MR I noticed that the link to the partial embed was removed, and the copy was added to the file, but the linked file was not deleted so there is now duplicate (and confusing content) around Manage goals in the codebase.

This MR serves as a suggested clean-up. I also want to do this on the individual (Import and Foundations) partials that may not be updated.

The following files are also added for deletion as they are no longer referenced in the main direction file and do not match the live direction page.

  • _themes.erb
  • _strategy.erb
  • _overview.erb
  • _next.erb
  • _intro.erb
  • _overview.erb
  • _groups.erb

CHANGEME - add the details saying why, not just what.

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
Edited by Christen Dybenko

Merge request reports