Skip to content

Fix team members listing for Reliability:General and Reliability:Observability

Gonzalo Servat requested to merge fix-daves-team-members into master

Why is this change being made?

💡 Provide a detailed answer to the question on why this change is being proposed, in accordance with our value of Transparency.

@dawsmith is the permanent team lead for Reliability:Observability and also the acting team lead for Reliability:General following Anthony's departure. We use the method direct_team() to build the table of team members with the parameter manager_slug: 'dave-smith'. Because Dave is the current lead for both teams, both the observability and general pages end up with the same team member listing, which is not ideal.

I've updated the direct_team() method to accept an optional department parameter. If specified, the team members have to match on the department. This MR also updates each of the team members to list either Reliability:General or Reliability:Observability as a department.

This MR supersedes !130437 (closed).

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

  • Provided a concise title for this Merge Request (MR)
  • Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
  • Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
    • The when to get approval handbook section explains the workflow in more detail
  • For transparency, share this MR with the audience that will be impacted.
    • Team: For changes that affect your direct team, share in your group Slack channel
    • Department: If the update affects your department, share the MR in your department Slack channel
    • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR

Edited by Gonzalo Servat

Merge request reports

Loading