Add Andrei Zubov to frontend maintainers
Justification
In my time in GitLab I've been part of several teams and touched different areas of our main codebase. Working with different people, in different domains, and reviewing many MRs from all over the codebase provided me a great overview on how our codebase is organised, what people should pay attention to while working on it, and potential common pitfalls people encounter. I believe that working together we will push GitLab further and achieve more, so I'm looking forward to joining the GitLab Front End Maintainers team
My approach to code reviews
When I review Merge Requests, I follow these principles:
- Understand the context I try to understand to the best of my knowledge, what was the issue and the problem, the MR is trying to solve. I don't hesitate to ask questions and don't assume I know better. There's most probably a good reason things are implemented the way they are, and I can always learn something new.
- Verify After that I check if I can reproduce the verification steps and try to think of any edge cases that might affect user experience or functionality of the feature
- UX I pay a lot of attention to UX and potential issues with it. I try to check, if the UI is consistent, the transitions are smooth and the implementation is matching the Design Docs or Pajama guidelines
-
Clarity and maintainability When checking the code, I try to spot potential issues with maintainability and clarity. I think it's valuable that the code is easy to understand, especially for people out of the context of the issue. Anyway, we all are out of the context when enough time has passed
😄 - Praise Good ideas, an elegant implementation, cleaning up along the way, things like these - should be praised, and I try to praise authors more often.
My recent review results
(last updated 2024-03-27)
Recently merged MRs: 41 (I've excluded MRs outside of gitlab
project codebase)
Stat | Result |
---|---|
Merged by maintainer with minimal or no changes | 36 |
Review thoroughness success rate | 88% |
MRs with more than minimal changes:
- gitlab-org/gitlab!136531 (merged)
- gitlab-org/gitlab!138932 (merged)
- gitlab-org/gitlab!139569 (merged) (changes are non-blocking though)
- gitlab-org/gitlab!142939 (merged) (a css class change)
- gitlab-org/gitlab!144081 (merged)
This one was merged as is, but later there was an issue discovered: gitlab-org/gitlab!137641 (merged)
Notable MRs
MR Link | Details |
---|---|
Fix loading icon for environment scope dropdown (gitlab-org/gitlab!124138 - merged) | Attention to UX |
Refactor New Objective form to be more generic (gitlab-org/gitlab!129628 - merged) | Attention to UX |
This MR improves quality of frontend test (gitlab-org/gitlab!112223 - merged) | Attention to Details |
Compliance framework report pagination + docs +... (gitlab-org/gitlab!112111 - merged) | Feature architecture and decomposition |
Context switcher search improvements (gitlab-org/gitlab!114643 - merged) | Maintainability and Tests |
Settings: Add sticky header and footer (gitlab-org/gitlab!124282 - merged) | Frontend and CSS |
UI for code snippets in the GitLab Duo (gitlab-org/gitlab!125308 - merged) | Collaboration and iteration |
Truncate time in environments page (gitlab-org/gitlab!131962 - merged) | Work with community contributors |
Additional contributions
Before Merging (Manager Tasks)
-
Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer). -
Mention the maintainers from the given specialty and ask them to provide feedback to the manager directly. -
Leave this merge request open for 1 week, to give the maintainers time to provide feedback. -
Ensure we have at least 2 approvals from existing maintainers.
Once This MR is Merged
-
Create an access request for maintainer access to gitlab-org/<project>
. -
Join the [at]frontend-maintainers
slack group -
Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists. -
Let a maintainer add you to gitlab-org/maintainers/frontend
withOwner
access level. -
Announce it everywhere -
Keep reviewing, start merging 🤘 😎 🤘
cc @nmezzopera