Skip to content

Make Rad Batnag a backend maintainer

Radamanthus Batnag requested to merge rad-team-member-change into master

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

@radbatnag has reviewed over 172 merged MRs and authored over 52 merged MRs

Trainee Backend Maintainer issue: https://gitlab.com/gitlab-com/www-gitlab-com/-/issues/34062+

Backend Maintainer Mentor: @splattael

  • Focuses on changes in MR and code quality 1, 2, 3, 4, 5, 6
  • Cares about performance impact 1
  • Encourages code readability and suggests re-use existing code when possible 1, 2, 3
  • Identifies and suggests adding missing tests and improves test quality 1, 2, 3, 4

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement, and can vouch for this proposal, please approve.

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  3. Let a maintainer add you to @gitlab-org/maintainers/rails-backend with Owner access level.
  4. Announce it everywhere
  5. Familiarize yourself with documentation for Merging a merge request
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Radamanthus Batnag

Merge request reports

Loading