Skip to content

Update atiwari71 as GitLab Backend Maintainer

Aditya Tiwari requested to merge atiwari71-maintainer-update into master

Introduction

@atiwari71 has reviewed over 206 merged MRs and authored over 254 merged MRs

Trainee Backend Maintainer issue: Aditya Tiwari's mentorship program (gitlab-org/gitlab#463235 - closed)

Backend Maintainer Mentor: @splattael @brytannia

Manager Justification

It's hard to specify hard requirements for becoming a maintainer, which is why the documentation consists of flexible guidelines. Reviewers are encouraged to think of their eligibility for maintainership in the terms of "I could be ready at any time to be a maintainer as long as my work as an author and reviewer is consistent with other maintainers".

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additional required changes.
  1. Migrate dependency list header to use latest_in... (gitlab-org/gitlab!161093 - merged)
  2. Backfills the user_details records for users th... (gitlab-org/gitlab!159632 - merged)
  3. Add assignment for experiment: project_template... (gitlab-org/gitlab!159582 - merged)
  4. Pass the QA User-Agent header to the CustomersD... (gitlab-org/gitlab!160214 - merged)
  5. Add answer chunk factory (gitlab-org/gitlab!161362 - merged)
  6. Rename SaxDocument to CoberturaDocument (gitlab-org/gitlab!158341 - merged)
  7. Refactor Geo Event Worker and Service (gitlab-org/gitlab!158303 - merged)
  8. ee/spec/features/search/elastic/group_search_sp... (gitlab-org/gitlab!158629 - merged)
  9. Add feature specs for persist broadcast message... (gitlab-org/gitlab!159457 - merged)
  10. Improve ProtectedRefAccess#humanize logic (gitlab-org/gitlab!156219 - merged)
  11. Improve ProtectedRefAccess#humanize logic (gitlab-org/gitlab!156219 - merged)
  12. Update dependency semver_dialects to v3.0.2 (gitlab-org/gitlab!156549 - merged)
  13. Resolve "FE: Show continuous container scanning... (gitlab-org/gitlab!152422 - merged)
  14. Set finding name when advisory title is not spe... (gitlab-org/gitlab!155841 - merged)
  15. Move container scanning for registry to new card (gitlab-org/gitlab!155202 - merged)
  16. Add DORA metrics over time datasource for Singl... (gitlab-org/gitlab!151885 - merged)
  17. Send user back to referer page after successful... (gitlab-org/gitlab!150624 - merged)
  18. [Feature flag] Cleanup native_header_anchors (gitlab-org/gitlab!152088 - merged)
  19. Remove use_database_for_dependencies_api featur... (gitlab-org/gitlab!152540 - merged)
  20. Improve UX for 404 error for Duo Pro trial page (gitlab-org/gitlab!153403 - merged)
  21. Remove unused EoA legacy method (gitlab-org/gitlab!152105 - merged)
  22. Remove unused EoA legacy method (gitlab-org/gitlab!152105 - merged)
  23. [Feature flag] Cleanup native_header_anchors (gitlab-org/gitlab!152088 - merged)
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.
  1. Add guideline to use example urls (gitlab-org/gitlab!160370 - merged)
  2. Update project dependencies export to filter re... (gitlab-org/gitlab!160846 - merged)
  3. Add license check to cs for registry (gitlab-org/gitlab!161771 - merged)
  4. Update container scanning for registry history log (gitlab-org/gitlab!159682 - merged)
  5. Enable container scanning for registry (gitlab-org/gitlab!156247 - merged)
  6. Resolve "[CS for Registry] Add Tracking for cs ... (gitlab-org/gitlab!154285 - merged)
  7. [CS for Registry] Limit Scans for Registry (gitlab-org/gitlab!154925 - merged)
  8. Add project level filter for dependency list (gitlab-org/gitlab!152045 - merged)
  9. Change scope container_scanning_for_registry FF (gitlab-org/gitlab!152970 - merged)
  10. Add CVS for CS document (gitlab-org/gitlab!154388 - merged)
  11. Move document for container scanning for registry (gitlab-org/gitlab!156259 - merged)
  12. Fixes beta link on Feature flag page (gitlab-org/gitlab!156263 - merged)
  13. Remove DEBUG from CS for registry job (gitlab-org/gitlab!155686 - merged)
  14. Add logs for ScanImageService (gitlab-org/gitlab!155401 - merged)
  15. Document removal of go.sum parsing in Dependenc... (gitlab-org/gitlab!154890 - merged)
  16. Fixes typo for CS JOB (gitlab-org/gitlab!154356 - merged)
  17. Bump security report schema to 15.1.1 (gitlab-org/gitlab!151118 - merged)

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action 
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement, and can vouch for this proposal, please approve.

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Join the #backend_maintainers Slack channel
  2. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists.
  3. Let a maintainer add you to @gitlab-org/maintainers/rails-backend with Owner access level.
  4. Announce it everywhere
  5. Familiarize yourself with documentation for Merging a merge request
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Peter Leitzen

Merge request reports