Skip to content

Make Andrew a Maintainer of CNG

Balasankar 'Balu' C requested to merge andrew-patterson-cng-maintainer into master

Justification

  • The MRs reviewed by the candidate consistently make it through maintainer review without significant additionally required changes.
  • The MRs authored by the candidate consistently make it through reviewer and maintainer review without significant required changes.

I believe Andrew is ready to become a Maintainer of CNG, based on his reviewed and authored MRs, and the fact that he along with Dmytro are our current SMEs in the CNG DSOP release process. He has shown extreme care while reviewing all the common forms of MRs that the current Maintainers deal with on a day to day basis. And I trust him to ask for help while reviewing MRs that might be out of his area of expertise.

Before Merging (Manager Tasks)

  • Close any relevant trainee maintainer issues with a comment indicating that this merge request is being created, as (they are no longer required to become a maintainer).
  • Update _maintainer project_ to the correct project in @gitlab-org/maintainers group below
  • Mention the maintainers from the given specialty with the template below.
  • Leave this merge request open for 1 week, to give the maintainers time to provide feedback.
  • Ensure we have at least 2 approvals from existing maintainers.
Template call to action 
SPECIALITY Maintainers, please review this proposal to make TRAINEE maintainer of PROJECT. 

* If you have blocking feedback adhering [to the documentation](https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer) please share it with me via Slack.
* If you are in agreement please approve the MR

After 1 week, if there is no blocking feedback and at least 2 approvals, I will merge this MR.

Once This MR is Merged

  1. Ask a maintainer to add you to https://gitlab.com/groups/gitlab-org/maintainers/cloud-native-images/ with Owner access level
  2. Join the #distribution_maintainers Slack channel
  3. Ask the maintainers in your group to invite you to any maintainer-specific meeting if one exists
  4. Announce it everywhere
  5. Familiarize yourself with documentation for Merging a merge request
  6. Keep reviewing, start merging 🤘 😎 🤘
Edited by Peter Lu

Merge request reports