Make James Fargher a BE maintainer
Trainee maintainer issue: #5224 (closed)
- Worked at GitLab since Jan 2019 (13 months)
- Mostly worked on Auto-DevOps and Kubernetes integration, but sporadically contributed to CI (gitlab-org/gitlab!16574 (merged)). rubocop (gitlab-org/gitlab!21873 (merged)) and elsewhere (gitlab-org/gitlab!22061 (merged)).
- Authored at least 72 merged MRs for
gitlab-org
https://gitlab.com/groups/gitlab-org/-/merge_requests?scope=all&utf8=%E2%9C%93&state=merged&author_username=proglottis - Maintainer of several smaller projects to support Auto-DevOps and Kubernetes managed apps (auto-build-image, auto-deploy-app, auto-deploy-image, cluster-applications, helm-install-image).
I think I would have worked with enough maintainers to achieve quorum, but just in case here are what I think would make me a good maintainer:
- I ask questions to clarify unfamiliar code and concepts (gitlab-org/gitlab!18205 (comment 228406554)). Related, I'm not afraid to admit when things are new/unknown to me (gitlab-org/gitlab!23784 (comment 279165724)).
- I don't just review the diff, but explore the surrounding code too (gitlab-org/gitlab!24049 (comment 281103911)). I think this helps me understand more deeply the context of the change (gitlab-org/gitlab!19208 (comment 237557600)) and to keep gitlab consistent (gitlab-org/gitlab!18205 (comment 228406552)).
- I spend time making sure my suggestions are justified and marking them "not blocking"/nit if not (gitlab-org/gitlab!23338 (comment 277759263))
- I'm a go reviewer. I like reviewing. I like learning about gitlab and helping others learn too (gitlab-org/gitlab!17646 (comment 222877337)).
Based on the feedback I've received so far, here is where I think I'm weakest:
- I tend to miss changelog wording.
- I'm inconsistent at calling up code readability issues like needing whitespace (This has at least cause me to fix some rubocop todos gitlab-org/gitlab#34182 (closed))
- When I review larger MR's I still get a lot post review of feedback. Not often major issues, but something to consider.
In addition I may need to think about limiting time I spend reviewing to make sure I get my own work done too. Review workload varies and
For your consideration @gitlab-org/maintainers/rails-backend
Closes #5224 (closed)