Make Etienne Baqué a GitLab BE maintainer
Trainee maintainer issue: #6822 (closed)
Overview
Experience at Gitlab:
- Joined GitLab as a Backend engineer on June 26th 2019 (a bit more than 1 year and 6 months ago, as of creation of this MR).
- 136 MRs authored in 2020, based on recent performance review.
- Joined Gitlab as part of the Release team (Progressive Delivery group). In November 2020, switched to the Fulfillment team (Utilization group).
Examples of reviews
- gitlab-org/gitlab!27229 (merged): First logged MR. Pointed at missing tests, suggested refactoring.
- gitlab-org/gitlab!30982 (merged): Suggested to use polymorphic association in this MR. This is where I learned that polymorphic associations were banned at GitLab :)
- gitlab-org/gitlab!34960 (merged): Suggested to move a piece of logic to a more relevant place and to update some AR queries. I also pointed to some relevant docs which the developer was not aware of.
- gitlab-org/gitlab!48363 (merged): Even though I didn't comment on anything related to backend, I suggested a change on the database side.
- gitlab-org/gitlab!25904 (merged): This is an interesting MR that's been going on for a while. I made many suggestions to the developer, like refactoring and breaking down this MR into multiple MRs (I helped by creating these new MRs for the developer). More details here.
Things to improve
- Get more familiar with GraphQL (never the opportunity to work with it yet, I was just exposed to it through review)
- Understand consequences of infra configuration changes. Making sure this type of changes are tested on .com or other envs.
- Be more aware about potential concurrency and backward-compatibility issues.
- When there are DB changes in addition to backend changes in a MR, pay also attention to database changes.
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Etienne Baqué