Skip to content

Added primary / secondary review to PMM review checklist.

Cormac Foster requested to merge cfoster3-master-patch-08322 into master

Why is this change being made?

Per this comment in the 13.10 release post retro, the 18th is too late in the process for this sort of review on a large scale, and the Messaging Lead may not have the domain expertise to understand the full scope of the situation that led to the initial assignment. Adding the primary / secondary review to the feature block review stage will ensure that the Messaging Lead will only have to make those calls in extreme circumstances.

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
    • If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping @gl-static-site-editor in a comment for a review and merge. For example changes to .gitlab-ci.yml, JavaScript/CSS/Ruby code or the layout files. (this requirement has been removed pending identification of a new DRI for the handbook)

Merge request reports