Skip to content

Clarify what MRs require Product Design review

Pedro Moreira da Silva requested to merge pedroms-master-patch-67283 into master

Why is this change being made?

Based on the discussions in gitlab-org/gitlab-design#1489 (closed), clarify what MRs require Product Design review, just like the already merged gitlab-org/gitlab!58032 (merged).

  1. Move link to Code Review guidelines to the top of the section.
  2. Link to Code Review approval guidelines.

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
    • If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping @gl-static-site-editor in a comment for a review and merge. For example changes to .gitlab-ci.yml, JavaScript/CSS/Ruby code or the layout files. (this requirement has been removed pending identification of a new DRI for the handbook)

Merge request reports