Add Doug Stull as Backend maintainer (Gitlab)
Trainee maintainer issue: #5430 (closed)
Howdy GitLab backend maintainers
I have been contributing as an engineer in Growth at GitLab for 22 months, as a member of groupexpansion, being a trainee maintainer for over a year. I have been learning Ruby and Rails since 2013.
I continue to learn each day and value the differing opinions and approaches I come upon while reviewing and being reviewed during the MR review process.
Recently I have participated in Database Rapid action where I contributed to improving performance along with many other engineers.
During my tenure at GitLab I have these stats to share:
- overall: 613 Merged MRs, 456 reviewed MRs that were merged.
- gitlab-org/gitlab: 259 Merged MRs, 258 reviewed MRs that were merged.
- gitlab-services/version-gitlab-com: 175 Merged MRs, 85 reviewed MRs that were merged.
- gitlab-services/customers-gitlab-com: 42 Merged MRs, 51 reviewed MRs that were merged.
- gitlab-org/license-gitlab-com(stepped down as maintainer to focus on GitLab trainee-maintainership): 42 Merged MRs, 5 reviewed MRs that were merged.
- Maintainer-On: gitlab-styles and gitlab-experiment. I Stepped down as maintainer on the following to focus on GitLab trainee-maintainership CustomersDot, Versions App(backend and frontend) and LicenseDot.
- Trainee Maintainer: GitLab(Database)
- gitlab-org/gitlab-styles: 26 Merged MRs with an effort to help MR review cycle time by investing in standardization and automatic linting.
Examples of reviews
- gitlab-org/gitlab!61847 (merged) - in-depth community contribution with multiple suggestions in different areas.
- gitlab-org/gitlab!57953 (merged) - various test optimizations
- gitlab-org/gitlab!61146 (merged) - suggested generalizing accounts instead of using personal ones.
- gitlab-org/gitlab!56698 (merged) - suggested breaking up MR for ease of review and improve some test coverage
- gitlab-org/gitlab!52537 (merged) - suggested various test, scoping in the class, and test stubbing improvements
- gitlab-org/gitlab!54080 (merged) - suggested approaches to simplify the code and possibilities to DRY up certain areas
Feature development examples
- Refactor user creation service to be more declarative
- Rapid action in relation to GroupMembers#index action and the follow-up for iteration and bringing it full circle to use pre-existing paradigm
- Measured approach to add invite source telemetry on group/project member invites
Things to improve
- continuously learn more about the product
@gitlab-org/maintainers/rails-backend
please chime in below with your thoughts, and
approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Doug Stull