Skip to content

Trigger 'lint release-post-items' job for changes in "source/images/unreleased/*"

Chad Woolley requested to merge caw-update-lint-release-post-items into master

Why is this change being made?

Trigger 'lint release-post-items' job for changes in "source/images/unreleased/*"

Details

lint release-post-items job failed due to some file being too large:

$ bundle exec bin/validate-release-post-item
pass data/release_posts/unreleased/access_Level_for_project_tokens.yml
pass data/release_posts/unreleased/add_pronouns_to_profile_snapdhot.yml
pass data/release_posts/unreleased/code-review-vs-code-checkout-mr-branch.yml
pass data/release_posts/unreleased/create-code-review-discussion-icon-vs-code.yml
pass data/release_posts/unreleased/external_mr_status_checks.yml
pass data/release_posts/unreleased/implementation-issue-for-template-button.yml
pass data/release_posts/unreleased/jira_mr_association.yml
pass data/release_posts/unreleased/ldap-synchronization-should-warn-before-it-kills-direct-member-lis.yml
pass data/release_posts/unreleased/manage-audit-events-compliance-framework.yml
pass data/release_posts/unreleased/manage-audit-events-instance-admins.yml
pass data/release_posts/unreleased/removal-outdated-browser-support.yml
pass data/release_posts/unreleased/users-should-receive-a-notification-when-they-are-blocked-or-deact.yml
error data/release_posts/unreleased/verify-pe-enable-secure-CIJOBTOKEN.yml: image source/images/unreleased/secure_ci_bot.png is too large 179127B

This was because !86375 (merged) changed an image, but that image path wasn't a trigger for the job.

This adds the image path, but this may still happen for images in other places.

However, we don't want to run this for ALL images changes, because it would cause the job to run on many MRs unnecessarily. But this will at catch this specific problem on future MRs.

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
  • Assign this change to the correct DRI
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
    • If the changes relate to any part of the project other than updates to content and/or data files please make sure to ping @gl-static-site-editor in a comment for a review and merge. For example changes to .gitlab-ci.yml, JavaScript/CSS/Ruby code or the layout files. (this requirement has been removed pending identification of a new DRI for the handbook)

Merge request reports