Skip to content

Change git log commit range for secret detection

Zach Rice requested to merge secret-detection-log-range into master

Why is this change being made?

When doing some investigation for gitlab-org/gitlab#349063 (closed) we discovered that the range of commits generated by git log in the secret_detection job has the potential to be wrong, and in some cases, time out the job.

This MR changes the ... operation to ... If we take main...feature as the example, the current ... syntax means "give us commits that are reachable from feature or main but not both". This means we could be including commits that are not associated with the MR when scanning for secrets. Using main..feature limits us to commits that are just in feature.

More reading:

Author Checklist

  • Provided a concise title for the MR
  • Added a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what
    • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added.
  • Assign reviewers for this change to the correct DRI(s)
    • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the "Maintained by" section in on the page being edited.
    • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies.
  • If the changes affect team members, or warrant an announcement in another way, please consider posting an update in #whats-happening-at-gitlab linking to this MR.
    • If this is a change that directly impacts the majority of global team members, it should be a candidate for #company-fyi. Please work with internal communications and check the handbook for examples.

Edited by Zach Rice

Merge request reports

Loading