Add seanarnold as a backend mantainer
Trainee maintainer issue: #6764 (closed)
Overview
I've been at GitLab since August 2019, working in the various forms of the ~"group::monitor" group as a backend engineer.
I've contributed > 200 MRs to GitLab related projects, and have reviewed & approved over 300 MRs as a backend reviewer and a CI/CD Templates reviewer.
My trainee maintainer issue has had positive feedback by maintainers, with most feedback being for minor misses.
Examples of reviews
Ability to ask questions to confirm prior & intended behaviour:
- gitlab-org/gitlab!74730 (merged)
- gitlab-org/gitlab!31449 (comment 344778267)
- gitlab-org/gitlab!70770 (comment 688471227)
In-depth reviews of the code on my local machine to confirm behaviour:
- https://gitlab.com/gitlab-org/security/gitlab/-/merge_requests/1885
- gitlab-org/gitlab!41598 (comment 411854975)
Other example reviews:
- Persist a Generic Alert information in the DB
- Add GraphQL mutation to create an alert issue
- Allow to pass
ended_at
to update Alert status GraphQL mutation - Provide PagerDuty integration data to frontend
- Support getting a todo for an alert in graphql api
- Ensure syntax highlighting limits are configurable
- Enable new Rails connection handling (leave context for reviewers)
Things to improve
- Review specs with the same vigour as the other code changes.
- Action: Take time to review specs. Take examples from other maintainers to learn specific things to pick up on.
- Become more aware of changes that may have an adverse effect on Gitlab.com
- Action: Follow recent incidents by listening in on Incident calls & reading Incident issues (incl any RCAs)
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR (see the maintainer list) -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Crystal Poole