Marc Shaw to Backend Maintainer
Trainee maintainer issue: #9408 (closed)
Overview
187 Authored Merge requests
134 Approved-by Merge requests
Examples of reviews
#9408 (comment 801874611)
#9408 (comment 812494348)
#9408 (comment 743785956)
Things to improve
Sometimes can tend to think that something is 'good enough' - ie, avoid 'over engineering', but sometimes I take this a bit far and need to find a better balance
Be more aware when to pass a review to a domain expert
@gitlab-org/maintainers/rails-backend please chime in below with your thoughts, and approve this MR if you agree.
Developer checklist
-
Before this MR is merged -
Mention @gitlab-org/maintainers/rails-backend
, if not done (this issue template should do this automatically) -
Assign this issue to your manager
-
-
After this MR is merged -
Request a maintainer from the #backend_maintainers
Slack channel to add you as an Owner togitlab-org/maintainers/rails-backend
-
Consider adding 'backend maintainer' to your Slack notification keywords
-
Manager checklist
-
Before this MR is merged -
The MR has been open for 5 working days -
More than half of the existing maintainers approve the MR (see the maintainer list) -
There are no blocking concerns raised (if there are, please follow https://about.gitlab.com/handbook/engineering/workflow/code-review/#how-to-become-a-project-maintainer)
-
-
After this MR is merged -
Announce the good news in the relevant channels listed in https://about.gitlab.com/handbook/engineering/#keeping-yourself-informed
-
Edited by Marc Shaw